injections.hdf contains events that are very close to each other

gwastro / ml-mock-data-challenge-1

Code and documentation for the first machine learning focused mock data challenge hosted by the Albert-Einstein-Institut Hannover and the Friedrich-Schiller Universität Jena.

Apache License 2.0

39 stars 16 forks source link

injections.hdf contains events that are very close to each other #8

Closed nnarenraju closed 2 years ago

nnarenraju commented 2 years ago

I took the "tc" values from injections.hdf, sorted them and found the difference between adjacent times. The minimum time duration between two adjacent "tc" is ~0.00019 seconds, and only 145 out of 583,847 injections have a difference of fewer than 6 seconds. All others are 24 seconds or above. Is this intentional?

Code snippet used to check the time difference: diff = np.sort(sorted_tc[1:] - sorted_tc[:-1])

MarlinSchaefer commented 2 years ago

Thanks for reporting this issue. It seems to be caused by pycbc_create_injections. I've posted an issue here. If the solution is merged, we might want to switch the version of PyCBC. Otherwise we could set in place a workaround.

I'll update this once we know which route we will take.

MarlinSchaefer commented 2 years ago

This is fixed by the pull request merged into PyCBC here. We will require the new version of PyCBC from now on.