search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
314 stars 351 forks source link

Workflow generator should be able to use remote executables #306

Closed lppekows closed 9 years ago

lppekows commented 9 years ago

PyInstaller can build static executables from the various ligolw_ programs needed at workflow-generation time, but at present the binaries have to be manually downloaded and placed in the PATH. The workflow generators should be able to resolve URLs.

ahnitz commented 9 years ago

Larne,

What happened when you tried? I'm a bit confused here. Did you not also set the jobs to be stageable? This can be done in the ini file setting the profile information for it, or perhaps it makes sence to always say that gsiftp urls are "stageable".

See,

https://github.com/ligo-cbc/pycbc/blob/master/pycbc/workflow/core.py#L159

lppekows commented 9 years ago

Hi Alex,

the issue is with programs that are needed at workflow-generation time, that is, anything that goes through make_external_call

https://github.com/ligo-cbc/pycbc/blob/master/pycbc/workflow/core.py#L1200

such as ligolw_segment_query, and it looks like at least some of these can't be deferred to the workflow

https://github.com/ligo-cbc/pycbc/blob/master/pycbc/workflow/segment.py#L200

Is there something I'm missing here?

ahnitz commented 9 years ago

Nope, I was just confused. You are right.

lppekows commented 9 years ago

Resolved by https://github.com/ligo-cbc/pycbc/pull/333