search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
313 stars 347 forks source link

Byte type and str comparison in io/hdf not compatible for Python3 #3489

Open Fergus-Hayes opened 3 years ago

Fergus-Hayes commented 3 years ago

Unlike python2, python3 distinguishes between byte and string types, resulting in the ValueError to be raised in:

https://github.com/gwastro/pycbc/blob/0c424d28187e87091d71d74003c806fc3a5b04ab/pycbc/io/hdf.py#L701

This could be fixed by ensuring ifo in self.ifos is of string type.

GarethCabournDavies commented 3 months ago

This is still in-place as of fc7bd0d. But we have been using python3 for years!