PyGRB post processing and results webpage

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.

http://pycbc.org

GNU General Public License v3.0

307 stars 345 forks source link

PyGRB post processing and results webpage #3660

Open pannarale opened 3 years ago

pannarale commented 3 years ago

We have a first take on the PyGRB results webpage in the standard PyCBC format here. Right now it has most of what was on the old webpages, but there is a lot more that can and should be done. So use this issue to bring up bugs, desiderata, etc.

pannarale commented 3 years ago

Still missing from the old pages

[x] GRB trigger information
[x] table of loudest offsource events with details
[ ] Values of 50% and 90% exclusion distances

pannarale commented 3 years ago

Known requests

[x] Include GPS times of injections in tables
[x] Follow up of loudest missed injections
[x] Follow up of loudest offsource events
[x] Sample the offtrials randomly (this requires changes to pycbc_grb_trig_combiner at line 464)
[x] Include in tables information regarding the spins of templates ringing with triggers/injections (this is postponed to after the switch to hdf5)
[ ] Sky maps with antenna responses

titodalcanton commented 3 years ago

@pannarale could you also consider the following requests:

[ ] I have a hard time reading found/missed injection plots. I propose using higher-resolution plots (try dpi=150 or dpi=200, or double the figure size), smaller symbols, consistent use of the makers (x = missed, o = found) and no mix of blue and black symbols.
[ ] Found/missed plots with some kind of optimal SNR on the y axis. Not sure which one gives the sharpest separation between found and missed in a coherent search though, so this may require comparing a few different choices (e.g. optimal network SNR or decisive optimal SNR).
[ ] Try a log10 FAP color scale, I suspect it would be more useful: 0.8 and 0.2 basically indicate the same conclusion, while 0.05 and 0.0005 imply very different results.
[ ] Add a tiny and very brief legend on the bottom left or bottom right of the figure, indicating what the various symbols mean.

pannarale commented 5 months ago

https://github.com/gwastro/pycbc/pull/4639 may need some fixes downstream in the post-processing, as noted in the PR's thread.

pannarale commented 3 months ago

[x] @jakeb245, per the discussion we had today about extract_basic_trig_properties, please add the argument opts in pycbc_pygrb_efficiency when the extract_basic_trig_properties function call happens.

pannarale commented 2 months ago

Moving more webpage/post-processing tasks here from issue #4419.

Comparing the latest results webpage to the most complete one generated when using old xml results files, the items missing are

[x] tables of missed and quiet injections (A31 and A32)
[x] follow ups of the 10 loudest quiet injections (sections 3.02 and 3.04, these are done for each injection set)
[x] all section 4, i.e., loudest offsource events distributions, table and follow ups of the 10 loudest
[x] all of section 5 (exclusion distances)

pannarale commented 2 months ago

On the basis of the April 2024 test I am marking some of the items in the previous comment as done. The remaining items are

[ ] reporting the exclusion distances
[ ] testing opening a box

pannarale commented 2 months ago

[x] @jakeb245, per the discussion we had today about extract_basic_trig_properties, please add the argument opts in pycbc_pygrb_efficiency when the extract_basic_trig_properties function call happens.

Done in https://github.com/gwastro/pycbc/pull/4718