search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
314 stars 351 forks source link

Update ECP authenticated pulls #3995

Closed spxiwh closed 2 years ago

spxiwh commented 2 years ago

@duncanmmacleod says we should replace the https code in https://github.com/gwastro/pycbc/blob/bc45bb13f3ff08d00de5e977e6b7b0a4fc61ff2f/pycbc/workflow/configuration.py#L199 with something like:

with Session(**kwargs):
    sess.get(...)

"""actually, if its a one-shot, you can probably just use ciecplib.get and ignore the session entirely """

Ian to look at this unless someone beats him to it. See also ciecplib.readthedocs.io.

duncanmmacleod commented 2 years ago

The idea of a one-shot doesn't work at all with git.ligo.org because it's not a proper ECP client, but there is a fairly elegant change that can be made. PR incoming.