search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
312 stars 347 forks source link

pycbc_plot_singles_timefreq should not query the datafind server at runtime #457

Closed duncan-brown closed 8 years ago

duncan-brown commented 8 years ago

pycbc_plot_singles_timefreq currently queries the datafind server at run-time to find it's input frames:

2015-10-09 08:45:20,078 Reading Frames
2015-10-09 08:45:20,079 querying datafind server
2015-10-09 08:45:20,132 found files: /frames/O1/L1_HOFT_C00/H1/L-L1_HOFT_C00-1127/L-L1_HOFT_C00-1127608320-4096.gwf /frames/O1/L1_HOFT_C00/H1/L-L1_HOFT_C00-1127/L-L1_HOFT_C00-1127608320-4096.gwf

This will break a lot of things (including running on XSEDE and other non-LDG clusters). The code should get its input frame data from the command line, as other codes do and tell Pegasus what data it needs via the DAX:

titodalcanton commented 8 years ago

The script already uses the recommended strain.from_cli() interface.

duncan-brown commented 8 years ago

Removed milestone pending further discussion with Karan on the best way to do this.

duncan-brown commented 8 years ago

Closing as with https://github.com/ligo-cbc/pycbc/pull/559 this is run on the local site anyway