search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
313 stars 347 forks source link

Get codeclimate to look at executables #4638

Open GarethCabournDavies opened 7 months ago

GarethCabournDavies commented 7 months ago

There is a rule on extensions where codeclimate decides which engine to use based on the file extension:

Furthermore, engines only run their analysis on files with an appropriate file extension for the language being analyzed (.rb for a Ruby engine, .py for a Python engine, etc). Therefore, in most cases you should not need to specify excludes for files in languages other than your target languages.

[https://docs.codeclimate.com/docs/excluding-files-and-folders#auto-generated-file-and-folder-exclusions](this page)

So if a file has no extension, it seems that nothing is done, but we want to use codeclimate to look at all the executables with the correct engine.

I don't know if we can use anything with the shebang to work this out?

GarethCabournDavies commented 7 months ago

(I had an idea in #4637, but it didn't work)

titodalcanton commented 6 months ago

Maybe worth posing the problem to the IGWN computing folks?

GarethCabournDavies commented 3 months ago

Maybe worth posing the problem to the IGWN computing folks?

So the consensus from that discussion (which I forgot to add at the time) was to update all executables to modules, and then use entry points.

That's quite a bit of work, but can be done one-at-a-time if wanted