Sort all quantities consistently in grb_inj_finder

[pannarale]

Standard information about the request

This is a: bug fix.

This change affects: PyGRB.

This change changes: result presentation / plotting, scientific output.

Motivation

The PyGRB workflows were showing inconsistent injection results in the output pages:

1. Network power chi-squares looked erratic

2. Differences between injection and recovery times were scattered all over the analysis time (for both injection sets used; the axes are in seconds)

3. Recovered chirp mass values were incompatible with the injected values.

Here is a webpage with these, but I will not keep it much longer at this point.

Contents

pycbc_grb_inj_finder was sorting timing information, extracting indices with argsort based on such sorted array and using them on other two arrays that had not been sorted the same way. These contain the SNR (coherent, reweghited, ..., it is a user choice) and the event_ids. This meant that the incorrect event_id was associated to each found injection, causing the issues in plots and tables outlined above. The fix is to simply sort the SNR and event_id arrays as the timing one, prior to using the argsorted indices on them.

Testing performed

Here is a plot of the same chi square after the fix.

It is taken from the regenerated version of the webpage for the example linked above.

Finally, a plot of the time differences (injected - recovered) for the two injection sets in this specific run.

• [x] The author of this pull request confirms they will adhere to the code of conduct

[pannarale]

I will add that this also cleans up the efficiency plots. Here is an example before and after the fix.