search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
307 stars 344 forks source link

Use pycbc conversions as single source of truth for converting seconds and years #4775

Closed GarethCabournDavies closed 2 weeks ago

GarethCabournDavies commented 1 month ago

Use the pycbc conversions sec_to_year function throughout so that there is a single source of truth for the conversion of seconds and years, and we dont call into lal for YRJUL_SI so much

Motivation

Solve #2885

Contents

Whenever the previous constant was being used, use the conversion function instead

tdent commented 1 month ago

Can you make this a draft until you think it's ready ?

GarethCabournDavies commented 1 month ago

I think it is ready now, but have just had a couple of bugs