search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
307 stars 344 forks source link

Use π phase shift to allow swap test for more modes #4777

Closed GarethCabournDavies closed 2 weeks ago

GarethCabournDavies commented 1 month ago

I'm not sure on whether this is actually tested for higher-order modes, but the sanity checks of test/lalsim.py should use this π phase shift in order to work for anything except 2,±2

Standard information about the request

This change affects the test suite

This change, follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines

Motivation

2126

Contents

Add a phase shift for the component swap test

titodalcanton commented 1 month ago

Have you verified that more approximants pass this test after this change, especially ones with HoMs?

GarethCabournDavies commented 1 month ago

Have you verified that more approximants pass this test after this change, especially ones with HoMs?

I have not, but HoMs is not really my area, I just implemented the suggestion in the issue :wink:

GarethCabournDavies commented 2 weeks ago

I ran the unit tests for lalsim and this makes no difference so I will close