gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
307 stars 344 forks source link

Handle RA and dec in radians in pygrb #4787

Closed pannarale closed 4 weeks ago

pannarale commented 1 month ago

This PR simply uses radians for right ascension and declination throughout PyGRB. Displaying them in degrees in the summary table on the results webpage is preserved. This cleanup fixes the single IFO vs coherent IFO diagnostic plots.

Standard information about the request

This is a: bug fix

This change affects: PyGRB

This change changes: result presentation / plotting

Motivation

The injections in plots such as

H1L1-PYGRB_PLOT_COH_IFOSNR_NSBH_GRB170728A_H1-1185258293-5648

with 2 IFOs or

H1L1V1-PYGRB_PLOT_COH_IFOSNR_ZOOMIN_NSBH_GRB170817A_H1-1187006058-5648

with 3 IFOs look wrong, but otherwise the behaviour of injections looks good. The PR ensures that R.A. and declination are handled consistently throughout the workflow, so that the resulting plots are now correspondingly

H1L1-PYGRB_PLOT_COH_IFOSNR_NSBH_GRB170728A_H1-1185258293-5648

and

H1L1V1-PYGRB_PLOT_COH_IFOSNR_ZOOMIN_NSBH_GRB170817A_H1-1187006058-5648-1

Testing performed

The updated plots were produced rerunning the entire workflow from injection production onwards (injection filtering, post-processing).