search

gwastro / pycbc

Core package to analyze gravitational-wave data, find signals, and study their parameters. This package was used in the first direct detection of gravitational waves (GW150914), and is used in the ongoing analysis of LIGO/Virgo data.
http://pycbc.org
GNU General Public License v3.0
307 stars 344 forks source link

require pre-numpy 2.0 #4789

Closed ahnitz closed 3 weeks ago

ahnitz commented 3 weeks ago

This pins to numpy < 2.0 while the transition is worked out. We'll need one final release with this requirement before switching to numpy 2.0 support.

titodalcanton commented 3 weeks ago

Do we need to edit pyproject.toml as well? I forget, but it was suggested to me.

ahnitz commented 3 weeks ago

Do we need to edit pyproject.toml as well? I forget, but it was suggested to me.

Yes, if we want it to work for python3.9. Once we drop that, we can actually build against 2.0 and it will work in numpy versions supported back to those using python3.10. They changed the way this works in numpy 2.0 to support backwards compatibility, but only to numpy versions that support the currently supported python version.

ahnitz commented 3 weeks ago

Not sure why build is failing on python 3.11. Running a test just to make sure that is the case and there aren't failures on the other versions. I can't reproduce on my laptop with python3.11 (no failures there) so unfortunately I'm resorting to trying here. Any ideas?