Closed GarethCabournDavies closed 3 months ago
Note that I haven't touched bin/plotting/pycbc_plot_bank_bins
, as that is already subclassing h5py.File, though I'm not sure whether the functionality which is there already exists elsewhere
I have also avoided live (due to efficiency worries) and inference, so as not to interfere with the h5py.File wrapper used there
Use pycbc.io.hdf's HFile class rather than h5py.File directly so that we can make changes to the functionality.
For example checksumming, version information, and anything else we may want
Standard information about the request
This is a change to utilise potential future features This change touches everywhere in the code, but affects nothing
This change follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Contents
Not quite find-and-replace, but update everywhere which uses h5py.File to pycbc.io.HFile
Links to any issues or associated PRs
1525 #4768
Testing
Broadly, this should be checked by the CI running
--help
for all executables