search

gwastro / sbank

GNU General Public License v2.0
4 stars 14 forks source link

Enable python3.9 wheels. #20

Closed spxiwh closed 3 years ago

spxiwh commented 3 years ago

@skymoo told me that we do have py39 lalsuite bundles, so let's try and see again why this wasn't working.

codecov-commenter commented 3 years ago

Codecov Report

Merging #20 (1966e73) into master (d5b2cda) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   20.94%   20.94%           
=======================================
  Files          11       11           
  Lines        1318     1318           
=======================================
  Hits          276      276           
  Misses       1042     1042
Flag Coverage Δ
Linux 20.94% <ø> (ø)
macOS 23.21% <ø> (ø)
python3.6 19.97% <ø> (ø)
python3.7 19.97% <ø> (ø)
python3.8 20.99% <ø> (ø)
python3.9 20.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5b2cda...1966e73. Read the comment docs.

spxiwh commented 3 years ago

@titodalcanton I figured out why python3.9 wheels weren't working after Adam pointed out that lalsuite 3.9 wheels do exist. It seems that lalsuite requires a slightly more modern linux to install if using 3.9. I've asked upstream why that is, but for now I mirror the lalsuite behaviour here. I'll try and figure out the mac stuff separately.