gwastro / sbank

GNU General Public License v2.0
4 stars 14 forks source link

LLwadd Executable is broken #25

Closed spxiwh closed 3 years ago

spxiwh commented 3 years ago

@MariaAssiduo noticed that the sbank_pipe executable is failing on python3 because the Llwadd executable defined in sbank is broken.

The reason for this is that a which function is defined to find the location of the executable, but this returns a bytes object and not an str object as expected. A simple fix is to decode bytes to str, but I'm not sure that using which here is a good idea, and the location for llwadd should be given in the config, just like the other executables.

.... Or I just remove sbank_pipe and make people use the PyCBC workflow generator.