The which function must return a str object

[spxiwh]

sbank_pipe currently fails on ligolw_add jobs because the path to the file is returned as a str. I'm not sure if I want to do some larger changes here and make the path to this executable be specified in the ini file. In the meantime I patch the existing method.

[codecov-commenter]

Codecov Report

Merging #26 (5e9a182) into master (0f141c1) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   20.94%   20.94%           
=======================================
  Files          11       11           
  Lines        1318     1318           
=======================================
  Hits          276      276           
  Misses       1042     1042           

Flag	Coverage Δ
Linux	20.94% <ø> (ø)
macOS	?
python3.6	19.97% <ø> (ø)
python3.7	?
python3.8	?
python3.9	20.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0f141c1...5e9a182. Read the comment docs.

[titodalcanton]

I propose a more radical change: replace the custom which implementation with a call to shutil.which, which seems to already return a string on Python 3.

[spxiwh]

I propose a more radical change: replace the custom which implementation with a call to shutil.which, which seems to already return a string on Python 3.

Good suggestion! (Probably one we could include in PyCBC's configparser stuff as well!)

[spxiwh]

Updated as requested.

[spxiwh]

fixes #25