gwastro / sbank

GNU General Public License v2.0
4 stars 15 forks source link

Banksim error with IMRPhenomXPHM and NRSur7dq4 waveforms #30

Closed MariaAssiduo closed 2 years ago

MariaAssiduo commented 3 years ago

I succesfully obtained two template banks with the family waveforms IMRPhenomXPHM and NRSur7dq4 using SBank. Now I am trying to calculate the effectualness of these banks using Banksim through the following tests: A (B). choosing the IMRPhenomXPHM as bank-seed (template-approximant) and the NRSur7dq4 as injections (signal-approximant) and viceversa;

I get the following errors: (A) pycbc_banksim: error: argument --template-approximant: invalid choice: 'IMRPhenomXPHM' (choose from 'EOBNRv2'....) (B) pycbc_banksim: error: argument --signal-approximant: invalid choice: 'IMRPhenomXPHM' (choose from 'EOBNRv2'....)

It seems that the waveforms IMRPhenomXPHM are not implemented in Banksim? How can I add them?

Thanks in advance.

MariaAssiduo commented 3 years ago

I searched in site-packages pycbc.waveform and looked the scripts bank.py and waveform.py but I cannot find the list of the templates approximant.

spxiwh commented 3 years ago

@MariaAssiduo It looks like you are using pycbc_banksim (which I would recommend as its good to have a banksim that is not tied to the bank generator .... If there's an issue in sbank, it will likely be present in sbank's banksim as well). I guess this makes this a PyCBC issue rather than an sbank issue.

If you are getting "invalid choice" for IMRPhenomXPHM then the version of lalsuite you are using with PyCBC is likely an old one (I think pycbc_inspiral --version will print off information about the lalsuite versions PyCBC is calling).

This then leads to a few questions:

spxiwh commented 3 years ago

PyCBC does not have an explicit list of waveforms as sbank does. It just asks lalsimulation directly what is available (sbank does not do this as it needs to identify whether waveforms have higher-order modes/precession).

That's also important: If you want to use the higher-order mode statistic for the templates you would need to use this PyCBC banksim executable https://github.com/gwastro/pycbc/blob/master/bin/pycbc_banksim_skymax with the option --sky-maximization-method hom.