search

gwatcha / reaper-keys

vim-bindings for Reaper
https://gwatcha.github.io/reaper-keys/
MIT License
141 stars 10 forks source link

Include data types in modules #64

Closed AntoineBalaine closed 3 months ago

AntoineBalaine commented 3 months ago

Hello,

Unfortunately, I can't just rebase my changes - my fork's gone far enough that it'd be a big hassle to go through that process. I might have more time to look into it a couple of weeks from now.

As a first step, I've gone through the process of including a types file for LuaLS to provide data typing inside the repo. No code or functionality have been touched. There's not much to know, and there's few warnings that are coming up as a result - which says good things about the original code.

I'd added a few function descriptions in comments for personal reference. I left them in, as a courtesy for future readers.

myrrc commented 3 months ago

LGTM, thanks for the PR.

myrrc commented 3 months ago

I'll batch some PR updates into index updates, otherwise Reapack index file will get too large.