search

gwatts / jquery.sparkline

A plugin for the jQuery javascript library to generate small sparkline charts directly in the browser
http://omnipotent.net/jquery.sparkline/
1.24k stars 278 forks source link

html validation fails #118

Open gcphost opened 10 years ago

gcphost commented 10 years ago

Hi

I like the tag option method but it renders invalid html, could these be changed to data tags please?

line 103: Attribute sparkheight not allowed on element span at this point. line 119: Attribute sparkbarcolor not allowed on element span at this point

data-spark-height data-spark-bar-color

etc

cburschka commented 7 years ago

I just encountered the same. Using invalid attribute names is extremely bad practice; this is a major bug.

timelyportfolio commented 7 years ago

the library seems to be inactive now. I have started to try to implement some changes in https://github.com/timelyportfolio/jquery.sparkline. If you are interested in making a pull, please let me know.