search

gwdevhub / GuildWarsPartySearch

Party Search Aggregator
1 stars 1 forks source link

max zoom is too limited #100

Open DubbleClick opened 2 months ago

DubbleClick commented 2 months ago

especially noticeable in Tyria - can't zoom out further than the max width being reached. this means that on a fully zoomed out tyria map, you can only see about a third of the map

AlexMacocian commented 2 months ago

Related to this #85

Zoom levels are based on the tiles that we have. I've limited the max zoom level so that you can't zoom out enough that you have black bars on the sides of the screen.

I don't know how to reconcile these two issues without redoing the tiles (and even then, it would still depend on screen size). We'd have to redo the tiles and all the coordinates of all the markers

DubbleClick commented 2 months ago

Having black bars on the sides of the screen is fine, having black bars on BOTH top/bottom and left/right should not be possible. If the library isn't capable of that, Then fuck it, just limit it to zzoom levels that mostly prevent blackbars on both sides.

AlexMacocian commented 2 months ago

Feel free to play with it. The jsons in the /data/ folder define the continents. In there I set up a max zoom and a min zoom property. Play with those until you get what you think should be the ideal effect