search

gwding / draw_convnet

2.64k stars 513 forks source link

Convert squares to rectangles. #3

Closed Aliases closed 6 years ago

Aliases commented 7 years ago

Hi @gwding

Here is my pull request :)

Should I create another branch or is it okay to compare across forks? Let me know what you'd prefer.

gwding commented 7 years ago

@Aliases I hacked some changes and it might roughly satisfy your needs. To make it genearlize better, the patch_size, size, size_list should all have tuples as their elements to represent rectangular patches. I would be nice if you have time to make those changes, otherwise I might do it later.

Aliases commented 7 years ago

@gwding : Thank you very much! I will make those changes, and let you know if I have other doubts :)

gwding commented 6 years ago

this is implemented in PR#7, closing