search

gweis / isodate

ISO 8601 date/time parser
BSD 3-Clause "New" or "Revised" License
155 stars 59 forks source link

Duration: support addition and subtraction with arrow objects #38

Closed flokli closed 7 years ago

flokli commented 8 years ago

This will allow isodate to support addition and substraction with arrow objects.

Currently, the __radd__ and __rsub__ methods are pending on crsmithdev/arrow#344, as arrow currently raises TypeError instead of returning NotImplemented (which results into python not looking at isodate's methods for that).

isodate suffers from the same issue (rasing TypeError instead of returning NotImplemented). This however won't affect the behaviour with arrow objects, so I'll address this in another PR.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.4%) to 94.242% when pulling 2a328d3b237c7db1aebf43524a6f9757e53b8e5a on flokli:arrow into 27d3bca47e4d39bd5038665726fb157577c5abfa on gweis:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.4%) to 94.242% when pulling 360888f0a65939c91fe01b212cdbb38a78650359 on flokli:arrow into 27d3bca47e4d39bd5038665726fb157577c5abfa on gweis:master.

flokli commented 8 years ago

All Python 3.2 builds will fail, as support for Python 3.0-3.2 has been dropped from pip. #39 addresses this.

gweis commented 7 years ago

Would this work for you?

72345c4573d588170bdd201a604395bf15d83957

flokli commented 7 years ago

@gweis Yes, this will also work for me, closing this PR. Thanks :-)

I annotated some things in 72345c4.