Closed hugovk closed 2 years ago
This has some overlap with PR https://github.com/gweis/isodate/pull/60.
I've put up a temporary fork with this Python 3.10 fix as isodate2 0.7.0 at https://pypi.org/project/isodate2/
Merge?
Fixed in the fork at https://github.com/isodate/isodate/pull/1.
The maintainer has indicated, separately to GitHub, that this is likely to be merged soon!
Fixes https://github.com/gweis/isodate/issues/58. Fixes https://github.com/gweis/isodate/issues/67.
Python 3.10 is due out on 2021-10-04, three weeks from now.
https://discuss.python.org/t/python-3-10-0rc2-is-now-available/10496?u=hugovk
This deprecation warning was added in Python 3.8:
DeprecationWarning: an integer is required (got type decimal.Decimal). Implicit conversion to integers using __int__ is deprecated, and may be removed in a future version of Python.
For example:
https://bugs.python.org/issue36048
In Python 3.10 it is now an error:
TypeError: 'decimal.Decimal' object cannot be interpreted as an integer
For example:
https://bugs.python.org/issue37999
Failing build without fix:
Passing build with fix:
isodate is downloaded from PyPI 33 million times a month, the 52nd most popular package (https://hugovk.github.io/top-pypi-packages/), therefore I recommend making a release before 2021-10-04.
This PR also switches from Travis CI to GitHub Actions and Coveralls to Codecov, taken from https://github.com/gweis/isodate/pull/66, because testing on Travis CI is more difficult now. It only adds testing for supported Python versions. Let me know if this commit should be dropped, but I'd recommend merging #66 as well.