gwenaelp / vue-diagrams

Diagram component for vue.js, inspired by react-diagrams
MIT License
283 stars 64 forks source link

The readme example throws errors #6

Open ajthinking opened 5 years ago

ajthinking commented 5 years ago

The example in the readme:

<template>
  <diagram :model="model"></diagram>
</template>
<script>
import { Diagram } from 'vue-diagrams';

export default {
  data() {
    const diagramModel = new Diagram.Model();

    const node1 = diagramModel.addNode("test2", 300, 200);
    const inPort = node1.addInPort("test");

    const node2 = diagramModel.addNode("test", 10, 300, 144, 80);
    const node2OutPort = node2.addOutPort("testOut");
    node2.addOutPort("testOut2");
    node2.color = "#00cc66";

    const node3 = diagramModel.addNode("test3", 10, 100, 72, 100);
    const node3OutPort = node3.addOutPort("testOut3");
    node3.color = "#cc6600";

    diagramModel.addLink(node2OutPort, inPort);
    diagramModel.addLink(node3OutPort, inPort);

    return {
      model: diagramModel
    };
  },

  components: {
    Diagram
  },
};
</script>

Throws 4 x

Error: <path> attribute d: Expected number, "MNaN,NaN CNaN,NaN…".

at app.js:60222

It is triggered by diagramModel.addLink(a,b);

Google Chrome | 73.0.3683.86 "vue": "^2.5.17",

gwenaelp commented 5 years ago

Hi @ajthinking,

Thanks for the issue. I was not able to take time to solve a lot of issues on this library, but I'm considering making a big update to solve some problems that library have and add more features soon. I'll keep you posted!

Apart of this problem, are you able to do what you want with the library?

jsuwala commented 5 years ago

For me, serialization and deserialization functions are very much needed to allow for the diagram to be persisted and restored.

ajthinking commented 5 years ago

Got, it thanks for the heads up! I love react-diagrams so really excited about this :) For my current project it is for visualizing database schemas. But it's good-to-have-feature only so might wait a bit.

gwenaelp commented 5 years ago

@jsuwala serialization and deserialization are already working on vue-diagrams. You can have a look at the storybook!

jsuwala commented 5 years ago

@gwenaelp - thanks! I missed those storybooks...

TonyMasse commented 3 years ago

@gwenaelp I fixed the bug causing the error message about attribute d. Expect PR shortly. You only have a Master branch (as in, no Dev branch), so submitting my PR to master.