gwenn / lemon-rs

LALR(1) parser generator for Rust based on Lemon + SQL parser
The Unlicense
48 stars 10 forks source link

missing arguments for virtual table #30

Closed glommer closed 1 year ago

glommer commented 1 year ago

I have the following statement:

CREATE VIRTUAL TABLE t3 using fts5(a,b,c);

It gets parsed to the Cmd:

Stmt(CreateVirtualTable { if_not_exists: false, tbl_name: QualifiedName { db_name: None, name: Name("t3"), alias: None }, module_name: Name("fts5"), args: None })

As you can see, the arguments disappeared.

if we call to_string() on it, indeed, we see:

CREATE VIRTUAL TABLE t3 USING fts5 (); # no arguments

CC @MarinPostma @psarna

gwenn commented 1 year ago

See #6

MarinPostma commented 1 year ago

I'll take a look at that

MarinPostma commented 1 year ago

If I understand correctly we need to port sqlite3VtabArgInit and sqlite3VtabArgExtend somehow

gwenn commented 1 year ago

Version 0.8.0 released

MarinPostma commented 1 year ago

Thanks