gwentcards / gwentcards.github.io

Witcher 3 Gwent cards checklist
9 stars 5 forks source link

DLC cards #25

Open CrowdedDread opened 1 year ago

CrowdedDread commented 1 year ago

Hello, Would it be possible to update the table and include cards from DLCs?

Hearts of Stone: 12 cards

Blood and Wine: 43 cards (Skellige deck)

I could help with the allcards.csv, but the rest is beyond my skills, eg. the progress bar. (I created an account for the sole purpose of writing this request.)

The tracker is awesome and I would like to see it up-to-date.

vzx commented 1 year ago

Hi CrowdedDread, it means a lot to me that you took the time to create an account to make this request!

Last year, I got a similar request to add Hearts of Stone cards: #22. I closed that one because the primary intention of the site was to track cards for the Card Collector achievement, while Hearts of Stone doesn't have a similar achievement, and the Blood and Wine quest and achievement has a tracker in game.

Since this is the 2nd request, I'm happy to reconsider and think about it again. :) Not making any promises though. ;)

I think the trickiest part would be to add an expansion part to the list, in case someone wants to track only cards from the base game (which would be me). UI design is not my strong point. An icon at the front or the back of the row would probably be simplest.

CrowdedDread commented 1 year ago

Please do reconsider, yours is the most elegant and user friendly tracker I've found!

I did not know that there is an in-game tracker for the Skellige deck, I'm not that far yet and I ignored gwent completely in my previous playthroughs. So that is something to look forward to. I also recently got the mod for tracking gwent cards (good for merchants and players, cards not so much). But I would still appreciate an out-of-the-game tracker more. :)

As for the trickiest part, perhaps add another column at the end with Wild Hunt/Hearts of Stone/Blood and Wine. And maybe 2 progress bars for HoS and B&W cards separately?

Anyway, thank you so much for sharing your tracker!

vzx commented 1 year ago

Hi @CrowdedDread, I finally took some time to look into this. I added the Hearts of Stone and Blood and Wine cards, and added a separate tracking bar for the expansions: https://gwentcards.github.io/ (if the changes don't show, hold the CTRL key while refreshing, to clear the cache and download the new version).

Thank you so much for providing the CSV file! That helped a lot and really saved me a ton of time implementing this!

May I ask your opinion about the following:

CrowdedDread commented 1 year ago

Hi @vzx, Wow! I really was not expecting you to do it so soon, what a pleasant surprise! Glad I could help with the csv.

As for my opinion:

Also one small request, could you change the colour of the bar for Skellige deck to purple, maybe this shade #663399?

I've also considered one other thing, some cards can be looted after you miss the opportunity to win them from the NPCs. Do you think it would be worth the time to update the details? I have some 6 cards in my head right now. I could update the csv again and also fix the mistakes I made :)

Once again, thank you so much for updating it so soon!

vzx commented 1 year ago

(Also when I was thinking about this I noticed I made a mistake with the King Bran card, could you please change the details to just “Beauclair, Ducal Camerlengo”?) (Another mistake: Schirrú is Win from NPC.)

Thanks, fixed both! There's some confusing info about the King Bran card on the internet, but I think indeed this is the most correct.

Also one small request, could you change the colour of the bar for Skellige deck to purple, maybe this shade #663399?

Yeah good one actually. So far I was only using the basic colors provided by the theme I'm using: https://getbootstrap.com/docs/4.0/utilities/colors/ I've changed Skellige into the one you recommended. If at some point you think the others could use a different color and it's not too time-consuming to figure out what the color codes are, I'd be happy to update those too. Small changes, but makes it all look just a little bit neater. :)

Gustfields

Thanks for sharing your perspective, then I will leave it as it is now. I'm not aiming to have the site match the lore 100% correctly, just to have a handy checklist to find stuff in-game. 😂

I've also considered one other thing, some cards can be looted after you miss the opportunity to win them from the NPCs. Do you think it would be worth the time to update the details? I have some 6 cards in my head right now. I could update the csv again and also fix the mistakes I made :)

With the big additions, the CSV file was really handy, but for smaller updates like this I think it's simpler to have the details in this ticket, which I can use to adjust the CSV file and then page accordingly. If it's not too much hassle, I would love to hear what the changes are. I do recall that when I set up the page the first time, there was a lot of mixed information about a lot of the cards online, especially a lot of differences between game versions and between platforms/consoles. I honestly didn't really bother to go through the game to check all the different details and variances, and mainly focused on "in my (PC) version of the game, this is where you could find them if you want to get all of them". I don't want to put too much text in the Details column, but some small additions with clarifications and extra opportunities (especially if certain NPCs go missing for example) are always good too add.

CrowdedDread commented 1 year ago

Hi, this one is gonna be perhaps a bit complicated :D.

For starters:

Thanks, fixed both!

Thank you!

If at some point you think the others could use a different color and it's not too time-consuming to figure out what the color codes are, I'd be happy to update those too.

I think the rest of the colours actually nicely corresponds to the colours of the decks.

But, you could also update the text at the bottom now that the whole thing is getting updated :) Based on the PC version of The Witcher 3: Wild Hunt - Game of the Year Edition v4.03


Now to the cards, there's 17 of them!!! I could not really decied whether update the Type as well, so I will not mind if you delete the "OR Loot" part, if you don't like it (or maybe add asterisk and a note at the bottom of the page?) I wrote the instructions where to loot to the best of my abilities and I actually checked most of them later in the game (it was real fun trying to beat Stjepan with my shitty deck :D, but I did it eventually). I've also added in parenthesis if there is an objective to find the card - this can be also deleted or rewritten. I split the card into groups based on their respective quest/expansion (I did not check Blood and Wine) and if they are received automatically if the character dies/disappears.

A Dangerous Game:

Gwent: Velen Players

Gwent: Playing Inkeeps:

(Kingfisher inkeep still sells the same cards after Olivier dies, but if played gives random card, so perhaps update the4 cards sold by Olivier as Kingfisher Inn, Olivier OR Innkeep)

Gwent: Old Pals:

Gwent: Skellige style

Automatically received cards:

Hearts of Stone:

That's all folks! (for now)

CrowdedDread commented 1 year ago

More comments:

delete the "OR Loot" part

Please, delete it.

body of Prison Warden during The Great Escape

The Great Escape, loot Prison Warden's body

Gwent: Old Pals OR Gwent: Play Thaler, The Seven Cats Inn, Thaler OR Seven Cats Inn, top of a crate at the end of the side dining hall

This could be shortened just to: Gwent: Old Pals OR Gwent: Play Thaler, The Seven Cats Inn, Thaler OR top of a crate at the end of the left dining hall

vzx commented 1 year ago

Thanks so much for all the pointers! I really appreciate all the time and effort you have been putting into this. I am a bit busy at the moment, so I haven't gotten around to integrating the changes just yet, but I feel confident that I can do it in the next week. :)

CrowdedDread commented 1 year ago

No need to rush. I just found out that some innkeeps in Toussaint also sell cards, so I'm checking that out. And maybe I'll have some additional changes. :)

EDIT: Seems like all the inkeeps in Toussaint sell cards but they overlap quite a bit, so I think there is no need to add it to the details.

CrowdedDread commented 1 year ago

Hello,

because there's more changes than I thought I updated the csv. :)

Change log:

Also Barclay Els and Vampire: Bruxa can be obtained durin B&W quest Till Death Do You Part - but I did not include that.

cards_updated and roach.csv

EDIT: Forgot the Roach card, added at the end of the csv.