search

gwforg / gwf

A flexible, pragmatic workflow tool.
https://gwf.app/
GNU General Public License v3.0
31 stars 12 forks source link

Failed targets are not recognized as failed #407

Open LudvigOlsen opened 9 months ago

LudvigOlsen commented 9 months ago

I have a job that failed but the summary says failed 0.

The target did not produce the expected output files before failing. If I call gwf run again, the job is submitted again.

billede

billede

billede

Skærmbillede 2023-10-18 kl 20 03 49

I have since fixed the error in the code so probably can't reproduce. But seems there might be a bug in gwf?

I'm running version 2.0.4.

dansondergaard commented 3 weeks ago

As far as I remember, if a target fails and doesn't produce the intended output files, it will be reported as "shouldrun". If it fails, but produced the files anyway, gwf will report it as "failed". It may not be a useful distinction, but in general thinks of target with missing/outdated output files as "shouldrun".