Add `result_error` to `simplify` function

gwihlidal / meshopt-rs

Rust ffi and idiomatic wrapper for zeux/meshoptimizer, a mesh optimization library that makes indexed meshes more GPU-friendly.

Apache License 2.0

163 stars 33 forks source link

Add `result_error` to `simplify` function #34

Closed BeastLe9enD closed 9 months ago

BeastLe9enD commented 1 year ago

The meshopt_simplify function has an optional result_error out param that meshopt-rs ignores. I added them as an Option<&mut f32>, I know this is a breaking change, but we should follow the original API as much as we can in my opinion.

Uriopass commented 9 months ago

I agree, it's good to follow the same API! And the fix is quite simple usually: just add None at the end if you don't care.

This PR currently has conflict so I'll do the commit myself with the same idea so I can publish everything today