search

gwillem / magento-malware-scanner

Scanner, signatures and the largest collection of Magento malware
GNU General Public License v3.0
679 stars 153 forks source link

Make debian packaging work out of the box #186

Closed andreas-bytenl closed 6 years ago

andreas-bytenl commented 6 years ago

If dh-python is not added as a build dependency, the Depends field will be filled with weird and incorrect values from setup.py's install_requires.

However, dh-python causes ${python:Depends} to be too strict. So just get rid of that and put in the python verison Depends manually.

I tested this using cowbuilder/pdebuild for Debian Stretch as well as Ubuntu Xenial.

Also see comments in https://github.com/gwillem/magento-malware-scanner/pull/185

vdloo commented 6 years ago

yup, works :+1: 

root@dd980a-magentomalwarescanner-magweb-vgr /data/web/public # dpkg -i python-mwscan_20180228.120927_all.deb 
(Reading database ... 62969 files and directories currently installed.)
Preparing to unpack python-mwscan_20180228.120927_all.deb ...
Unpacking python-mwscan (20180228.120927) over (20170208.125606) ...
Setting up python-mwscan (20180228.120927) ...
root@dd980a-magentomalwarescanner-magweb-vgr /data/web/public # apt-cache depends python-mwscan
python-mwscan
  Depends: python
  Depends: python
  Depends: python-psutil
  Depends: python-yara
  Depends: python-requests
gwillem commented 6 years ago

Great, thanks!

vdloo commented 6 years ago

@gwillem could you tag a new release for this one?

gwillem commented 6 years ago

Done! 20180302.141503