search

gwillen / herring

Modern Django and ReactJS based web application for puzzlehunt team management!
MIT License
7 stars 4 forks source link

Bot gets confused when a round is missing channels #25

Open gwillen opened 3 years ago

gwillen commented 3 years ago

If some puzzles in a round are missing channels, the bot fails mid-interaction when performing e.g. hb!join or hb!who menus on that round.

Ideally this should never come up if #24 gets fixed. But just in case, we should also fix this issue. One option would be to turn every call that requests a puzzle channel into a wrapper that creates it if it doesn't exist. Another would be to at least display a sensible menu, whether or not we include the missing puzzle, and also yell somehow about the missing puzzle.

My guess is maybe we should have a channel where the bot can send errors, and ping some role to come look at them, rather than having them just sitting in a logfile somewhere, unloved.

gwillen commented 3 years ago

This is at least partly fixed. There may be instances of this left, but at least when rendering puzzles for a category join menu, we won't crash if a channel is missing.