search

gwinndr / MusicTransformer-Pytorch

MusicTransformer written for MaestroV2 using the Pytorch framework for music generation
MIT License
236 stars 48 forks source link

TMIDI RPR Edition #12

Closed asigalov61 closed 3 years ago

asigalov61 commented 3 years ago

@gwinndr This is a fully working TMIDI + Google Magenta note-seq rpr which is native to your implementation. Plus brand new and improved Google Colab + Python 3 code.

Enjoy!

Merge or branch. Either way is fine with me. Just wanted to save you time and help you to make it work.

Alex

gwinndr commented 3 years ago

Killer! I'll take a look at this tomorrow or Wednesday.

asigalov61 commented 3 years ago

@gwinndr Thanks. I think it plays quite well. However, compare and see what works best because I use more precise timings in my own encoding which I think produced slightly better results. You have both implementations now so compare and choose what you like best and what works best in your opinion.