search

gwinndr / MusicTransformer-Pytorch

MusicTransformer written for MaestroV2 using the Pytorch framework for music generation
MIT License
235 stars 48 forks source link

Patch 1 #17

Closed CNelias closed 2 years ago

CNelias commented 2 years ago

I added a function for preprocessing custom midi files (outside of maestro), as well as a new argument for the parser to specify whether or not the data are from the maestro dataset.

gwinndr commented 2 years ago

Looks good, will add one very minor change to argument parsing

gwinndr commented 2 years ago

The action="store_true" basically tells argparse that this is a boolean variable that is true when you specify it.

So python preprocess_midi.py path/to/root --custom_dataset will set the custom_dataset toggle to true. If unspecified, it's false.

Damon

On Thu, May 26, 2022 at 7:37 AM Corentin Nélias @.***> wrote:

If you don't mind me asking, what does the keyword action do? I've never seen it so far. I know it's in the doc, but the doc isn't very explicit.

— Reply to this email directly, view it on GitHub https://github.com/gwinndr/MusicTransformer-Pytorch/pull/17#issuecomment-1138438772, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYGP2XZEFFF5QUGZOCYD3TVL5O6LANCNFSM5WZURKAQ . You are receiving this because you modified the open/close state.Message ID: @.***>