search

gwlim / openwrt-sfe-flowoffload-ath79

Openwrt firmware with SFE and FlowOffload
201 stars 24 forks source link

AUG image does not have the software offload checkmark in firewall settings #54

Closed Pentaphon closed 5 years ago

Pentaphon commented 5 years ago

As the title says, there's no checkmark. No way to see if software offload is enabled.

gwlim commented 5 years ago

It has changed to a button. Isn't that better? Btw Openwrt Software Offload is broken in Trunk. Only SFE works and it is faster

Pentaphon commented 5 years ago

Btw Openwrt Software Offload is broken in Trunk.

Is that the real reason the checkmark is gone? Or did you disable the checkmark because you know software offload is broken in trunk?

It has changed to a button. Isn't that better?

Don't you mean only SFE has changed to a button? Not software offload?

Only SFE works and it is faster

I compared both SFE and software offloading on my Archer C7 v2 and unfortunately, software offloading is faster than SFE on this hardware. I guess I will keep this issue open until software offloading comes back to these builds.

gwlim commented 5 years ago

I moved the kmod into the tar.gz you can install it from the tar.gz if you want. But the checkbox will not show up the JS is broken with the module Just curious, how did you compare?

Pentaphon commented 5 years ago

In previous versions of your builds when the checkmark was there I tried SFE alone and software offloading alone. Software offloading was without a doubt faster on my Archer C7 v2 so I just kept using software offloading. However, I did a clean install when upgrading to this AUG firmware. I guess I will just have to downgrade to the last version with working software offload.

gwlim commented 5 years ago

No the question was HOW do you determine which is faster?

Pentaphon commented 5 years ago

I did numerous speed tests with each of them enabled alone, and none enabled. Software offloading alone gave me the fastest throughput every single time on the Archer C7 v2. Not sure why. Perhaps software offloading is the only stable solution for this hardware right now.

gwlim commented 5 years ago

I did numerous speed tests with each of them enabled alone, and none enabled. Software offloading alone gave me the fastest throughput every single time on the Archer C7 v2. Not sure why. Perhaps software offloading is the only stable solution for this hardware right now.

It is not so simple. I am not sure you did the test correctly. I certainly hope you didn't use speedtest as a benchmark. And SFE actually works with SQM but Flow Offload doesn't. It obeys ratelimits set via QDisc It is actually a foregone conclusion that SFE is faster 1) It uses prefetch/branch likely/unlikely to optimize packet processing 2) It uses alignment to optimize memory accesss ( I just improved this for AUG released with lots of testing) 3) I tested using iperf/jperf countless times and SFE is definitely a magnitude faster.

Pentaphon commented 5 years ago

Did you test it on the Archer C7 v2? Because I honestly get the opposite result with this hardware.

gwlim commented 5 years ago

Did you test it on the Archer C7 v2? Because I honestly get the opposite result with this hardware.

I have C7 v4 and WDR4300 both running the MIPS74k CPU at different frequencies. When doing benchmarking did you control the variables? Did you activate some other feature at some time? Anyone else using the network? ISP speed if you are using speedtest? Speedtest server consistent performance? (That is why speedtest is not a benchmark) Did you open the gui on other internet browsers? All this can affect the result. If you activate SQM and do both test of course Flow Offload will be faster because Flow Offload does not obey SQM while SFE does.

Pentaphon commented 5 years ago

I don't use SQM because it slows down everything and it has never fixed bufferbloat for me on my Archer C7 v2. I tried Flow Offload alone and SFE alone, and Flow Offload always gave me a better result in real world performance. When I enable SFE on a clean install of your AUG build, I cannot even get to my 200mbps line speed, while Flow Offload always fulfills my line speed and beyond. I cannot explain why other than online speedtests, real world download performance, and transferring files via the network from device to device.

isbecker commented 5 years ago

So, does this mean that the process for enabling SFE no longer requires going into the Network->Firewall to click the checkbox?

Meaning, just going into System->Startup and Enabling, then starting SFE (and reboot).

I do see in the syslog:

Mon Jul 22 16:29:59 2019 kern.alert kernel: [   27.245457] fast-classifier: starting up
Mon Jul 22 16:29:59 2019 kern.alert kernel: [   27.249627] fast-classifier: registered

So, does that meaning that SFE is on and running?

Edit: I guess there was never a checkbox in the Firewall section for SFE. But there was at least an indication that it was enabled. Is that no longer there?

gwlim commented 5 years ago

You can see the button on the firewall page. FlowOffload kmods are in the tar.gz if you want to use FlowOffload download and install from the zip archive.