search

gwmod / nlmod

Python package to build, run and visualize MODFLOW 6 groundwater models in the Netherlands.
https://nlmod.readthedocs.io
MIT License
35 stars 3 forks source link

Incomplete knmi ts breaks get_recharge function #269

Closed bdestombe closed 1 year ago

bdestombe commented 1 year ago

Solution provided by Davíd.

Missing values are filled with nearby time series by setting fill_missing_obs to True

rubencalje commented 1 year ago

I updated the fill_missing_obs functionality in hydropandas this week. It does not check if de Bilt has measurements anymore, if this is not needed (when no data needs to be filled). So we maybe need to increase the hydropandas version in the next nlmod release (if the new hydropandas has been released).

rubencalje commented 1 year ago

Also, evaporation-measurements were not filled in Hydropandas. This has been fixed in a PR last week: https://github.com/ArtesiaWater/hydropandas/pull/157

OnnoEbbens commented 1 year ago

I've updated hydropandas and pinned the version in the requirements of nlmod. I would like to merge this PR and release a new nlmod version asap. After that we can transfer nlmod to a new organisation without any open PR's.