search

gwmod / nlmod

Python package to build, run and visualize MODFLOW 6 groundwater models in the Netherlands.
https://nlmod.readthedocs.io
MIT License
35 stars 3 forks source link

set_ds_time changes ds inplace #274

Closed bdestombe closed 11 months ago

bdestombe commented 1 year ago

Most of the other functionality returns a Dataset that can be used to update ds, however the set_ds_time function in dims/time.py is one of the few that changes ds inplace.

rubencalje commented 1 year ago

In the latest version of the dev-branch set_dds_time does not alter the original model Dataset anymore. So I think this is already fixed.

dbrakenhoff commented 1 year ago

I can confirm the original input dataset is not modified. A new dataset is returned containing a "time" coordinate and data variables "steady", "nstp" and "tsmult".

If this is also working for you @bdestombe, we can close this issue I think.

bdestombe commented 11 months ago

Thanks guys. I cannot reproduce it anymore..