gwmod / nlmod

Python package to build, run and visualize MODFLOW 6 groundwater models in the Netherlands.
https://nlmod.readthedocs.io
MIT License
35 stars 3 forks source link

Rename remove_nan_layers to 'remove_inactive_layers' or 'remove_zero_thickness_layers' #300

Open bdestombe opened 11 months ago

bdestombe commented 11 months ago
          we should probably rename this to 'remove_inactive_layers' or 'remove_zero_thickness_layers'.

With the move to internally always assume modflow-style layer models (with one top and N bottoms), renaming this kwarg would make it more clear what we're doing.

We do need to maintain some backward compatibility though, so we should add the new name and throw a DeprecationWarning for the old one. Up to you whether you open a new issue for this or add it as part of this PR :).

_Originally posted by @dbrakenhoff in https://github.com/gwmod/nlmod/pull/295#discussion_r1404281903_