search

gwmod / nlmod

Python package to build, run and visualize MODFLOW 6 groundwater models in the Netherlands.
https://nlmod.readthedocs.io
MIT License
34 stars 3 forks source link

remove gridtype from dataset attributes #344

Open dbrakenhoff opened 5 months ago

dbrakenhoff commented 5 months ago

Proposal by @rubencalje: Instead of checking gridtype we check for icell2d.

Explain somewhere in docs that this is the way to check whether you're using a vertex/structured grid. Maybe add a method get_grid_type(ds)?

rubencalje commented 5 months ago

In the future we will probably also support disu-grids. @martinvonk has some experience with these grids. This will introduce something like an inode-dimension, and remove the layer dimension. We can add the layer as an optional variable in the model dataset, for models that still consist of layers.

A dis-grid we call a 'structured' grid and a disv-grid we call a 'vertex' grid. How do we call a disu-grid? Or do we just check for an inode-dimension?

OnnoEbbens commented 5 months ago

Flopy uses 'structured' (DIS), 'vertex' (DISV) and 'unstructured' (DISU) so I would use the same terminology.