search

gwmod / nlmod

Python package to build, run and visualize MODFLOW 6 groundwater models in the Netherlands.
https://nlmod.readthedocs.io
MIT License
31 stars 2 forks source link

Fix regis URL #352

Closed rubencalje closed 2 months ago

rubencalje commented 3 months ago

This PR simplifies the REGIS- and GeoTOP-urls, to the openda[-server named on https://www.dinoloket.nl/modelbestanden-aanvragen/netcdf. It also sets the version of the netcdf4 package to below 1.70, because of issue #353.

bdestombe commented 2 months ago

Hi Ruben, Why did you limit the netCDF4 versions only in the CI and the creation of the documentation, and not in the main dependency list of nlmod (https://github.com/gwmod/nlmod/blob/b7fb73f6a9b2cf79efcdc74e508e43d2a44a7228/pyproject.toml#L26 )?

rubencalje commented 2 months ago

Hi Ruben, Why did you limit the netCDF4 versions only in the CI and the creation of the documentation, and not in the main dependency list of nlmod (https://github.com/gwmod/nlmod/blob/b7fb73f6a9b2cf79efcdc74e508e43d2a44a7228/pyproject.toml#L26 )?

Because I could not reprise the error on my Windows pc, so I thought maybe it is only a linux-problem. And I did not want to restrict package versions too much.

bdestombe commented 2 months ago

Ah but what about Davíd and the few other crazy Linux users? ;)

In my case, I use nlmod as a dependency and the CI of my scripts are failing because of it. To me it would have made sense if it would have been added to the main dependecy list of nlmod.