search

gwnrtools / nr-catalog-tools

A unified interface to various catalogs of Numerical Relativity simulations of compact binary mergers.
https://github.com/gwnrtools/nr-catalog-tools
GNU General Public License v3.0
1 stars 5 forks source link

Add Waveformtools to requirements.txt #23

Closed prayush closed 1 year ago

prayush commented 1 year ago

Add @vaishakp's waveformtools to requirements.txt. Its currently only used in a unit test.

vaishakp commented 1 year ago

Before this is merged, waveformtools must be published in pypi right?

prayush commented 1 year ago

Before this is merged, waveformtools must be published in pypi right?

No, pip can often install packages from their git repo directly. And this definitely seems to be the case for waveformtools. E.g. try pip install git+https://gitlab.com/vaishakp/waveformtools@main.

vaishakp commented 1 year ago

Will waveformtools @ git+https://gitlab.com/vaishakp/waveformtools@main then work in requirements.txt (untill i publish)?

prayush commented 1 year ago

Will waveformtools @ git+https://gitlab.com/vaishakp/waveformtools@main then work in requirements.txt (untill i publish)?

yes, I've tested it. I suggest you also verify by saving the following as a txt file and pip installing it (in a fresh conda env):

# Modules to install
numpy
scipy
lalsuite
ligo-common
pycbc
pandas
sxs[ecosystem]
waveformtools @ git+https://gitlab.com/vaishakp/waveformtools@main
vaishakp commented 1 year ago

Sure. We can go ahed. I will be able to check soon.