search

gwnrtools / nr-catalog-tools

A unified interface to various catalogs of Numerical Relativity simulations of compact binary mergers.
https://github.com/gwnrtools/nr-catalog-tools
GNU General Public License v3.0
1 stars 5 forks source link

Include requirements.txt in setup.py #27

Closed adivijaykumar closed 1 year ago

adivijaykumar commented 1 year ago

setup.py doesn't take in the requirements (!). This means that the installed package from pypi won't really work well.

adivijaykumar commented 1 year ago

@prayush @vaishakp any idea why the tests are failing? They are failing on master too with an import error,

vaishakp commented 1 year ago

@prayush @vaishakp any idea why the tests are failing? They are failing on master too with an import error,

Checking

vaishakp commented 1 year ago

@prayush @vaishakp any idea why the tests are failing? They are failing on master too with an import error,

Checking

This was due to a minor bug in wftools. On merging the PR #26, things should be fine.

prayush commented 1 year ago

@adivijaykumar is there anything holding up this PR now?