search

gwnrtools / nr-catalog-tools

A unified interface to various catalogs of Numerical Relativity simulations of compact binary mergers.
https://github.com/gwnrtools/nr-catalog-tools
GNU General Public License v3.0
1 stars 5 forks source link

Generate waveform polarizations #3

Closed vaishakp closed 1 year ago

vaishakp commented 1 year ago

Generate waveform polarizations for an observer from NR data.

prayush commented 1 year ago

@vaishakp this PR is quickly becoming quite large. It might be easier to factor out smaller pieces of it and get them merged first and faster. For e.g.,

  1. Changes to requirements.txt, environment.yml et can be a separate merge
  2. Changes to setup.py etc can be separate
  3. Changes to utils.py can be its own standalone merge.
  4. Code in lvc.py can be its own merge
adivijaykumar commented 1 year ago

@vaishakp how much time do you estimate PR is going to take before it becomes ready? The current master has breaking changes that would be resolved only by this PR (see #22 for a PR that will needs #3 to be merged). If it will take more time, I would suggest that we split this into separate PRs, with one of them only having basic formatting fixes that were breaking flake8.

vaishakp commented 1 year ago

I will push the changes in an hour.

vaishakp commented 1 year ago

This can now be merged. Testing is not yet completed. I will open a new PR for tests.