search

gwnrtools / nr-catalog-tools

A unified interface to various catalogs of Numerical Relativity simulations of compact binary mergers.
https://github.com/gwnrtools/nr-catalog-tools
GNU General Public License v3.0
1 stars 5 forks source link

Bugfix generate polarizations #31

Closed vaishakp closed 1 year ago

vaishakp commented 1 year ago

This commit adds two features and fixes some bugs in the computation of the waveform polarizations.

Feature add:

  1. Inherit WaveformModes.filepath and WaveformModes.sim_metadata from catalog for SXS.
  2. Presently, MAYA data does not provide the NR t_ref but instead Omega. Added method to compute this from Omega and the l2m2 orbital phasing.

These ensure that get_td_waveform works on all catalog data. Changes:

  1. Move the computation of the reference orbital phase from lvc to waveforms.

Bug fix:

  1. fixed variable mismatch in get_td_waveform method.

Duplicate of #26.

prayush commented 1 year ago

Note that this was reviewed as #26