search

gwnrtools / nr-catalog-tools

A unified interface to various catalogs of Numerical Relativity simulations of compact binary mergers.
https://github.com/gwnrtools/nr-catalog-tools
GNU General Public License v3.0
1 stars 5 forks source link

Fix polarization convention #36

Closed vaishakp closed 1 year ago

vaishakp commented 1 year ago

Conjugate waveform to comply with lal convention.

vaishakp commented 1 year ago

Good catch.

Can you please add a quick unit test for convention also, so we catch this deviation going forward.

E.g. generate a lalsimulation waveform (say, using SEOBNRv3) and compare both of its polarizations with NR data. For this purpose it'll be easiest to pick the same sim whose data you've included as part of this repo (so unit tests don't keep downloading data all the time). All we will need from the comparison is just a basic correlation of signs, as with the opposite convention the cross (x) polarization gets an overall minus (-) sign.

Actually the test in

Good catch.

Can you please add a quick unit test for convention also, so we catch this deviation going forward.

E.g. generate a lalsimulation waveform (say, using SEOBNRv3) and compare both of its polarizations with NR data. For this purpose it'll be easiest to pick the same sim whose data you've included as part of this repo (so unit tests don't keep downloading data all the time). All we will need from the comparison is just a basic correlation of signs, as with the opposite convention the cross (x) polarization gets an overall minus (-) sign.

This test is included in #33, where it also compares the waveforms pointwise.

prayush commented 1 year ago

This test is included in https://github.com/gwnrtools/nr-catalog-tools/pull/33, where it also compares the waveforms pointwise.

Then this looks ready to merge. @vaishakp could you remove the "draft" status!

prayush commented 1 year ago

This test is included in #33, where it also compares the waveforms pointwise.

Then this looks ready to merge. @vaishakp could you remove the "draft" status!

Nvm, just did that :)