gwokae / phpsvnclient

Automatically exported from code.google.com/p/phpsvnclient
0 stars 0 forks source link

Files with spaces in their name will be falsely categorized as directories #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Setup the svnphpclient
2. var_dump($svn->getFile('file with spaces');

What is the expected output? What do you see instead?
The expected output is the contents of the file.
The recieved output is bool(false)

What version of the product are you using? On what operating system?
r.50 on windows / PHP5

Original issue reported on code.google.com by rasmusbergpalm@gmail.com on 28 Oct 2009 at 3:55

GoogleCodeExporter commented 9 years ago
2. var_dump($svn->getFile('file with spaces')); ofc.

Original comment by rasmusbergpalm@gmail.com on 28 Oct 2009 at 3:56

GoogleCodeExporter commented 9 years ago
I found the error. Executing requests with whitespaces in would return 404 
which would 
return false which lead to the false assuption that the file was a folder.
I've attached a diff containing a hack to work around this by replacing spaces 
with %20

Cheers, Rasmus.

Original comment by rasmusbergpalm@gmail.com on 28 Oct 2009 at 5:23

Attachments:

GoogleCodeExporter commented 9 years ago
Sorry for the delay, I was not notified by mail of any pending issues and as 
you can
tell, the project is far from complete or as yet in a fully workable state.
I will look at the patch ASAP and add it to the source.

Many thanks for your contribution

Original comment by deadpan...@gmail.com on 2 Dec 2009 at 7:16

GoogleCodeExporter commented 9 years ago

Original comment by deadpan...@gmail.com on 8 Dec 2009 at 11:13