search

gwokhov / Deadline

A simple TODO with countdown timer
GNU General Public License v3.0
146 stars 28 forks source link

F-Droid inclusion #4

Open Poussinou opened 5 years ago

Poussinou commented 5 years ago

Hi,

Since this app is GNU GPLv3 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app by yourself, would it be ok for you if someone else do it for you?

gwokhov commented 5 years ago

I'm not against and support the inclusion, and glad if someone helps me to submit.😊

IzzySoft commented 5 years ago

@Gwokhov there are problems with the tag name (v1.0-beta06) and the versionName (1.0 beta06) which don't match, so that release cannot be built (automatically). The tag name should always include the versionName literally (the two are used to detect updates, together with the then increased versionCode).

In general I'd suggest not to have spaces in the versionName. For now the easiest thing would be renaming the tag (replacing the space by a "-" so it matches versionName) – unless the one commit since then justifies a new release.

Further, versionName and tag name suggest this was not the first (but rather the 6th) release (versionCode confirms this). Please don't delete tags for older versions (they don't eat space :smile:).

For reference, this is the packaging request @Poussinou opened for your app. See the second post:

INFO: ...skipping version 1.0 beta06 - Generated by import.py - check/set version fields and commit id

Which is the short variant of the first two paragraphs. Another thing it shows is an issue with your gradle; that doesn't have effect on F-Droid (the gradle will be replaced there), but rather on your own builds, so you will wish to fix that.

Thanks for bringing your app to F-Droid! Please ping me (or Possinou) once above issues are fixed, so we can trigger the inclusion process to bring it to the next level.

RichyHBM commented 5 years ago

Hello, any updates on this? I'd love to try this app!

IzzySoft commented 5 years ago

@Gwokhov if you could fix the gradle (replacing the "blank" by a "-" so versionName matches the tag name)?

gwokhov commented 5 years ago

@IzzySoft Problem solved, I am sorry for replying after so long.

IzzySoft commented 5 years ago

@Gwokhov thanks! One more step needed, though: Could you move the corresponding tab to point to a commit where the fix is already merged (like 8fe7886)?

gwokhov commented 5 years ago

@IzzySoft Is that ok if I just delete the old release tag directly (1.0-beta06), and replace it by the new commit version?

IzzySoft commented 5 years ago

AFAIK that's the only way it can be achieved – so: yes, it should be OK.

gwokhov commented 5 years ago

@IzzySoft ok, already update the tag 😀.

IzzySoft commented 5 years ago

Thanks! Let's see how the bot responds now (I've just triggered it).