Decrease coupling between debug interface and debugging engines

gwomacks / php-debug

Atom Text Editor package for PHP debugging

MIT License

119 stars 31 forks source link

Decrease coupling between debug interface and debugging engines #1

Open gwomacks opened 9 years ago

gwomacks commented 9 years ago

Need to refactor code base so other debugging engines can be integrated with the interface

dpo commented 8 years ago

Is this still in the cards? It would be great to plug in debuggers for other languages.

nsrosenqvist commented 7 years ago

Does this mean that it would allow for a default debugger interface with different language drivers? That sounds like something that the Atom IDE project would be interested in contributing with.

nsrosenqvist commented 7 years ago

Recently noticed that atom-ide-ui plans to integrate the Nuclide debugger in the future and I guess they would provide a language agnostic ui for it with drivers for different languages, like how they've integrated different ide-features through the Language Server Protocol. Here's the issue mentioning the plans: https://github.com/facebook-atom/atom-ide-ui/issues/75

mostafaeweda commented 6 years ago

I just finished v1 of atom-ide-debugger as part of https://ide.atom.io/ with some debuggers initially supported:

Node Debugger: https://atom.io/packages/atom-ide-debugger-node
Python Debugger: https://atom.io/packages/atom-ide-debugger-python
React Native Debugger: https://atom.io/packages/atom-ide-debugger-react-native
C/C++ GDB Debugger: https://atom.io/packages/atom-ide-debugger-native-gdb
OCaml Debugger: https://atom.io/packages/atom-ide-debugger-ocaml

There will be more debugger backends coming + third party debuggers can be easily integrated.

cchamplin commented 6 years ago

This was also handled with the release of atom-debug-ui: https://atom.io/packages/atom-debug-ui

At the moment this package looks like it's directly competing with atom-ide-debugger, but I'm not sure that atom-ide-debugger has all the functionality atom-debug-ui does so this requires further investigation

nsrosenqvist commented 6 years ago

@cchamplin I believe that atom-ide-debugger will be the preferred alternative since that is from the official atom-ide project and will undoubtedly receive more attention and support (850 stars vs 0 stars) . It was recently decoupled from the nuclide-debugger and it's a very elegant and simple to use debugger.

cchamplin commented 6 years ago

@nsrosenqvist understood. The development of atom-debug-ui predates the atom-ide/atom-ide-debugger package, so the overlap was accidental. With 0.3.0 landing today, and switching to the new ui backend provided via atom-debug-ui it's more or less just bad timing with the release of atom-ide-debugger last month.

Unfortunately I have a number of other projects to maintain/devote my time to; so another rewrite of PHP-Debug for a different UI package is not going to be possible for me personally for at least 6 to 12 months. Especially because some of the functionality PHP-Debug requires might need to be added upstream into atom-ide-debugger.

nsrosenqvist commented 6 years ago

@cchamplin, sorry to hear that! It's very unfortunate timing indeed. I trust that the new update to php-debug will serve us well in the meantime, thank you for the hard work you've invested into the project!