gwomacks / php-debug

Atom Text Editor package for PHP debugging
MIT License
119 stars 31 forks source link

Conditional breakpoint settings will not close and save condition #172

Closed stianborgesen closed 6 years ago

stianborgesen commented 8 years ago

If I right click at breakpoint, and open breakpoint settings, I can input my condition. Even multiple conditions. My problem occurs when I want to store the condition, and exit this view. I can't find a button for this. And clicking outside of the view does not work.

I was however able to keep the conditional breakpoint by opening the developer tools in Atom and deleting the DOM element representing the breakpoint settings.

Am I missing something, or should there be something like a button to close this view?

willwh commented 8 years ago

I ran in to this same issue, did you figure this out @stianborgesen ?

cchamplin commented 8 years ago

I will check into reproducing this.

cchamplin commented 8 years ago

Can you tell me what atom theme you are using? There should be an "x" in the top right corner of the breakpoint settings overlay.

willwh commented 8 years ago

@cchamplin sorry I've been using PHPStorm, but I would love to have this working well in Atom. I'm using the one-dark theme - https://github.com/atom/one-dark-ui

I do indeed see an "X" in the modal for setting breakpoint settings; however, it seems, once you hit the "X" -> the breakpoint gets removed altogether, making this feature useless :)

image

Please let me know if there is any other information I can provide that would be helpful, I wrote a blog post about it, which I'd love to improve with conditional breakpoint instructions :)

cchamplin commented 8 years ago

Just to to double check, after you input your conditional are you clicking the "Add condition" before clicking the "X"? In retrospect I realize this is not especially intuitive.

willwh commented 8 years ago

Yes! On Sun, Oct 16, 2016 at 12:49 Caleb Champlin notifications@github.com wrote:

Just to to double check, after you input your conditional are you clicking the "Add condition" before clicking the "X"? In retrospect I realize this is not especially intuitive.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/gwomacks/php-debug/issues/172#issuecomment-254069771, or mute the thread https://github.com/notifications/unsubscribe-auth/AAYUPMn5vJ-roUOKR_08i3jfwgVLxZwjks5q0n-zgaJpZM4JDGxr .

venatiodecorus commented 7 years ago

I'm running into the same issue, except when I click the X (after inputting my conditions and clicking "Add condition") the breakpoint disappears, but the Breakpoint list still lists a breakpoint but the line number changes to 1, and there is no visible breakpoint in the gutter.

stephenharris commented 7 years ago

I've getting this issue too (version 0.2.4). However, I also found that by leaving the "add condition" overlay open with the condition added, and running the application, then the condition would apply. Closing the overlay once (if) the breakpoint was hit would remove the breakpoint, but the script would still be halted at that breakpoint.

So the breakpoint is lost when the overlay is closed.

cchamplin commented 6 years ago

Should be fixed in v0.3.0