search

gwomacks / php-debug

Atom Text Editor package for PHP debugging
MIT License
119 stars 31 forks source link

"Enable Statusbar Buttons" config option has no affect. #278

Closed PHLAK closed 6 years ago

PHLAK commented 6 years ago

Toggling the Enable Statusbar Buttons option has no affect. The status bar buttons remain present no matter what.

Expected behavior: Toggling the Enable Statusbar Buttons options off should remove the buttons from the statusbar.

OS: Ubuntu 17.10 Atom v1.26.1 php-debug v0.3.0

cchamplin commented 6 years ago

Are you talking about the "Allow PHP-Debug to be opened from the Atom status bar" setting? I've tested this on both Windows and Ubuntu and it appears to be working correctly.

PHLAK commented 6 years ago

I'm talking about the Enable Statusbar Buttons option as seen here:

screenshot 2018-05-04 22 10 08

and how that option has no effect on the statusbar buttons as seen here:

screenshot 2018-05-04 22 08 19

PHLAK commented 6 years ago

Okay, I just saw the Allow PHP-Debug to be opened from the Atom status bar option you mentioned and that did remove those buttons. So what does the Enable Statusbar Buttons option do?

cchamplin commented 6 years ago

I see, it looks like what's happened is the settings UI is showing settings that no longer exist after the 0.3.0 update. My suggestion would be to remove all the PHP-Debug Settings from config.cson and see if they stop appearing.

PHLAK commented 6 years ago

My suggestion would be to remove all the PHP-Debug Settings from config.cson and see if they stop appearing.

This worked, thanks.