search

gwomacks / php-debug

Atom Text Editor package for PHP debugging
MIT License
119 stars 31 forks source link

Closing both tabs via status bar buttons does not stop listening to XDebug #291

Closed ghost closed 6 years ago

ghost commented 6 years ago

I do not have the "Continue to listen ... even if the debugger windows are all closed" option disabled, but even when I hide (perhaps this is the problem) both docks via their respective status bar buttons, breakpoints are still being triggered.

When I initially open the window, this is not the case. Perhaps the problem is that I am "hiding" the docks and not actually closing them?

iamsophiesk commented 6 years ago

I have this option disabled, but I experienced this problem today. I did some debugging, minimised the dock, continued to use the site, and I kept hitting breakpoints.

This behaviour continued after I minimised the dock, closed the tabs individually (clicking 'x' next to pane titles), and by clicking "Stop debugging".

cchamplin commented 6 years ago

This should be fixed in the next release (sometime this week). There is a flag that's sent to xdebug but to disable multiple connections but it looks like xdebug is ignoring this in certain situations.

cchamplin commented 6 years ago

Should be Fixed in v0.3.5. If not please reopen