gwosc-tutorial / gwosc-catalog

Scripts and modules to be used in community catalog uploads to GWOSC website
0 stars 0 forks source link

Schema #19

Closed jroulet closed 5 months ago

jroulet commented 5 months ago

This implements Python classes to instantiate a Catalog object, plus updates to the schema.

martinberoiz commented 5 months ago

In the README there are still references to name, description, etc instead of catalog_name, catalog_description. Missing release_date in the README as well and same with the other changes.

If you don't have time and want me to complete it I can do it too.

martinberoiz commented 5 months ago

IIUC this will fix #5, #9, #13, #14, #17 is that right?

jroulet commented 5 months ago

Yes, this fixes #5, #9, #13, #14, #17 but also #15 and #16 (#15 in the sense that it allows one to include network SNR or any other search statistic, although it doesn't enforce it).

If you could update the README it would be great, thanks!

martinberoiz commented 5 months ago

Ok, great. I'll merge and continue from here.

martinberoiz commented 5 months ago

Oh, I think I should have let you merge? Anyway, damage is done now, sorry :(